Source/modules/webdatabase/DatabaseTracker.cpp - Issue 794223003: Cheaper thread-safe atomic initialization of static references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/DatabaseTracker.cpp

Issue 794223003: Cheaper thread-safe atomic initialization of static references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add type check for initial value Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webdatabase/DatabaseTracker.cpp

diff --git a/Source/modules/webdatabase/DatabaseTracker.cpp b/Source/modules/webdatabase/DatabaseTracker.cpp

index f5e16d43f4380d6047d9af423c006bc758ed7a1b..e919e2c1adaf3979146a2882cf232779b83e3bc7 100644

--- a/Source/modules/webdatabase/DatabaseTracker.cpp

+++ b/Source/modules/webdatabase/DatabaseTracker.cpp

@@ -59,7 +59,7 @@ static void databaseClosed(Database* database)

DatabaseTracker& DatabaseTracker::tracker()

{

- AtomicallyInitializedStatic(DatabaseTracker&, tracker = *new DatabaseTracker());

+ AtomicallyInitializedStaticReference(DatabaseTracker, tracker, new DatabaseTracker);

return tracker;

}

« no previous file with comments | « Source/modules/webdatabase/Database.cpp ('k') | Source/modules/webdatabase/QuotaTracker.cpp » ('j') | Source/wtf/Threading.h » ('J')