Source/core/page/NetworkStateNotifier.cpp - Issue 794223003: Cheaper thread-safe atomic initialization of static references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/NetworkStateNotifier.cpp

Issue 794223003: Cheaper thread-safe atomic initialization of static references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add type check for initial value Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/NetworkStateNotifier.cpp

diff --git a/Source/core/page/NetworkStateNotifier.cpp b/Source/core/page/NetworkStateNotifier.cpp

index a2dcad38422b0f68f5e25f81cc6fd82e1fb29ff8..2cc33a9250b79976e7b4da0356b030f4e643ab15 100644

--- a/Source/core/page/NetworkStateNotifier.cpp

+++ b/Source/core/page/NetworkStateNotifier.cpp

@@ -39,8 +39,8 @@ namespace blink {

NetworkStateNotifier& networkStateNotifier()

{

- AtomicallyInitializedStatic(NetworkStateNotifier*, networkStateNotifier = new NetworkStateNotifier);

- return *networkStateNotifier;

+ AtomicallyInitializedStaticReference(NetworkStateNotifier, networkStateNotifier, new NetworkStateNotifier);

+ return networkStateNotifier;

}

void NetworkStateNotifier::setOnLine(bool onLine)

« no previous file with comments | « Source/core/fetch/FetchUtils.cpp ('k') | Source/core/timing/MemoryInfo.cpp » ('j') | Source/wtf/Threading.h » ('J')