Cheaper thread-safe atomic initialization of static references.

Source/platform/graphics/ImageDecodingStoreTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 22 matching lines @@
 #include <gtest/gtest.h>
 
 using namespace blink;
 
 namespace {
 
 class ImageDecodingStoreTest : public ::testing::Test, public MockImageDecoderClient {
 public:
     virtual void SetUp()
     {
-        ImageDecodingStore::instance()->setCacheLimitInBytes(1024 * 1024);
+        ImageDecodingStore::instance().setCacheLimitInBytes(1024 * 1024);
         m_data = SharedBuffer::create();
         m_generator = ImageFrameGenerator::create(SkISize::Make(100, 100), m_data, true);
         m_decodersDestroyed = 0;
     }
 
     virtual void TearDown()
     {
-        ImageDecodingStore::instance()->clear();
+        ImageDecodingStore::instance().clear();
     }
 
     virtual void decoderBeingDestroyed()
     {
         ++m_decodersDestroyed;
     }
 
     virtual void frameBufferRequested()
     {
         // Decoder is never used by ImageDecodingStore.
         ASSERT_TRUE(false);
     }
 
     virtual ImageFrame::Status status()
     {
         return ImageFrame::FramePartial;
     }
 
     virtual size_t frameCount() { return 1; }
     virtual int repetitionCount() const { return cAnimationNone; }
     virtual float frameDuration() const { return 0; }
 
 protected:
     void evictOneCache()
     {
-        size_t memoryUsageInBytes = ImageDecodingStore::instance()->memoryUsageInBytes();
+        size_t memoryUsageInBytes = ImageDecodingStore::instance().memoryUsageInBytes();
         if (memoryUsageInBytes)
-            ImageDecodingStore::instance()->setCacheLimitInBytes(memoryUsageInBytes - 1);
+            ImageDecodingStore::instance().setCacheLimitInBytes(memoryUsageInBytes - 1);
         else
-            ImageDecodingStore::instance()->setCacheLimitInBytes(0);
+            ImageDecodingStore::instance().setCacheLimitInBytes(0);
     }
 
     RefPtr<SharedBuffer> m_data;
     RefPtr<ImageFrameGenerator> m_generator;
     int m_decodersDestroyed;
 };
 
 TEST_F(ImageDecodingStoreTest, insertDecoder)
 {
     const SkISize size = SkISize::Make(1, 1);
     OwnPtr<ImageDecoder> decoder = MockImageDecoder::create(this);
     decoder->setSize(1, 1);
     const ImageDecoder* refDecoder = decoder.get();
-    ImageDecodingStore::instance()->insertDecoder(m_generator.get(), decoder.release());
-    EXPECT_EQ(1, ImageDecodingStore::instance()->cacheEntries());
-    EXPECT_EQ(4u, ImageDecodingStore::instance()->memoryUsageInBytes());
+    ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder.release());
+    EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries());
+    EXPECT_EQ(4u, ImageDecodingStore::instance().memoryUsageInBytes());
 
     ImageDecoder* testDecoder;
-    EXPECT_TRUE(ImageDecodingStore::instance()->lockDecoder(m_generator.get(), size, &testDecoder));
+    EXPECT_TRUE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), size, &testDecoder));
     EXPECT_TRUE(testDecoder);
     EXPECT_EQ(refDecoder, testDecoder);
-    ImageDecodingStore::instance()->unlockDecoder(m_generator.get(), testDecoder);
-    EXPECT_EQ(1, ImageDecodingStore::instance()->cacheEntries());
+    ImageDecodingStore::instance().unlockDecoder(m_generator.get(), testDecoder);
+    EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries());
 }
 
 TEST_F(ImageDecodingStoreTest, evictDecoder)
 {
     OwnPtr<ImageDecoder> decoder1 = MockImageDecoder::create(this);
     OwnPtr<ImageDecoder> decoder2 = MockImageDecoder::create(this);
     OwnPtr<ImageDecoder> decoder3 = MockImageDecoder::create(this);
     decoder1->setSize(1, 1);
     decoder2->setSize(2, 2);
     decoder3->setSize(3, 3);
-    ImageDecodingStore::instance()->insertDecoder(m_generator.get(), decoder1.release());
-    ImageDecodingStore::instance()->insertDecoder(m_generator.get(), decoder2.release());
-    ImageDecodingStore::instance()->insertDecoder(m_generator.get(), decoder3.release());
-    EXPECT_EQ(3, ImageDecodingStore::instance()->cacheEntries());
-    EXPECT_EQ(56u, ImageDecodingStore::instance()->memoryUsageInBytes());
+    ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder1.release());
+    ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder2.release());
+    ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder3.release());
+    EXPECT_EQ(3, ImageDecodingStore::instance().cacheEntries());
+    EXPECT_EQ(56u, ImageDecodingStore::instance().memoryUsageInBytes());
 
     evictOneCache();
-    EXPECT_EQ(2, ImageDecodingStore::instance()->cacheEntries());
-    EXPECT_EQ(52u, ImageDecodingStore::instance()->memoryUsageInBytes());
+    EXPECT_EQ(2, ImageDecodingStore::instance().cacheEntries());
+    EXPECT_EQ(52u, ImageDecodingStore::instance().memoryUsageInBytes());
 
     evictOneCache();
-    EXPECT_EQ(1, ImageDecodingStore::instance()->cacheEntries());
-    EXPECT_EQ(36u, ImageDecodingStore::instance()->memoryUsageInBytes());
+    EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries());
+    EXPECT_EQ(36u, ImageDecodingStore::instance().memoryUsageInBytes());
 
     evictOneCache();
-    EXPECT_FALSE(ImageDecodingStore::instance()->cacheEntries());
-    EXPECT_FALSE(ImageDecodingStore::instance()->memoryUsageInBytes());
+    EXPECT_FALSE(ImageDecodingStore::instance().cacheEntries());
+    EXPECT_FALSE(ImageDecodingStore::instance().memoryUsageInBytes());
 }
 
 TEST_F(ImageDecodingStoreTest, decoderInUseNotEvicted)
 {
     OwnPtr<ImageDecoder> decoder1 = MockImageDecoder::create(this);
     OwnPtr<ImageDecoder> decoder2 = MockImageDecoder::create(this);
     OwnPtr<ImageDecoder> decoder3 = MockImageDecoder::create(this);
     decoder1->setSize(1, 1);
     decoder2->setSize(2, 2);
     decoder3->setSize(3, 3);
-    ImageDecodingStore::instance()->insertDecoder(m_generator.get(), decoder1.release());
-    ImageDecodingStore::instance()->insertDecoder(m_generator.get(), decoder2.release());
-    ImageDecodingStore::instance()->insertDecoder(m_generator.get(), decoder3.release());
-    EXPECT_EQ(3, ImageDecodingStore::instance()->cacheEntries());
+    ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder1.release());
+    ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder2.release());
+    ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder3.release());
+    EXPECT_EQ(3, ImageDecodingStore::instance().cacheEntries());
 
     ImageDecoder* testDecoder;
-    EXPECT_TRUE(ImageDecodingStore::instance()->lockDecoder(m_generator.get(), SkISize::Make(2, 2), &testDecoder));
+    EXPECT_TRUE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), SkISize::Make(2, 2), &testDecoder));
 
     evictOneCache();
     evictOneCache();
     evictOneCache();
-    EXPECT_EQ(1, ImageDecodingStore::instance()->cacheEntries());
-    EXPECT_EQ(16u, ImageDecodingStore::instance()->memoryUsageInBytes());
+    EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries());
+    EXPECT_EQ(16u, ImageDecodingStore::instance().memoryUsageInBytes());
 
-    ImageDecodingStore::instance()->unlockDecoder(m_generator.get(), testDecoder);
+    ImageDecodingStore::instance().unlockDecoder(m_generator.get(), testDecoder);
     evictOneCache();
-    EXPECT_FALSE(ImageDecodingStore::instance()->cacheEntries());
-    EXPECT_FALSE(ImageDecodingStore::instance()->memoryUsageInBytes());
+    EXPECT_FALSE(ImageDecodingStore::instance().cacheEntries());
+    EXPECT_FALSE(ImageDecodingStore::instance().memoryUsageInBytes());
 }
 
 TEST_F(ImageDecodingStoreTest, removeDecoder)
 {
     const SkISize size = SkISize::Make(1, 1);
     OwnPtr<ImageDecoder> decoder = MockImageDecoder::create(this);
     decoder->setSize(1, 1);
     const ImageDecoder* refDecoder = decoder.get();
-    ImageDecodingStore::instance()->insertDecoder(m_generator.get(), decoder.release());
-    EXPECT_EQ(1, ImageDecodingStore::instance()->cacheEntries());
-    EXPECT_EQ(4u, ImageDecodingStore::instance()->memoryUsageInBytes());
+    ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder.release());
+    EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries());
+    EXPECT_EQ(4u, ImageDecodingStore::instance().memoryUsageInBytes());
 
     ImageDecoder* testDecoder;
-    EXPECT_TRUE(ImageDecodingStore::instance()->lockDecoder(m_generator.get(), size, &testDecoder));
+    EXPECT_TRUE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), size, &testDecoder));
     EXPECT_TRUE(testDecoder);
     EXPECT_EQ(refDecoder, testDecoder);
-    ImageDecodingStore::instance()->removeDecoder(m_generator.get(), testDecoder);
-    EXPECT_FALSE(ImageDecodingStore::instance()->cacheEntries());
+    ImageDecodingStore::instance().removeDecoder(m_generator.get(), testDecoder);
+    EXPECT_FALSE(ImageDecodingStore::instance().cacheEntries());
 
-    EXPECT_FALSE(ImageDecodingStore::instance()->lockDecoder(m_generator.get(), size, &testDecoder));
+    EXPECT_FALSE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), size, &testDecoder));
 }
 
 } // namespace