Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: Source/wtf/Threading.h

Issue 794223003: Cheaper thread-safe atomic initialization of static references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2007 Justin Haygood (jhaygood@reaktix.com) 3 * Copyright (C) 2007 Justin Haygood (jhaygood@reaktix.com)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 12 matching lines...) Expand all
23 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 23 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
24 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 24 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
25 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 25 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 26 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
27 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 */ 28 */
29 29
30 #ifndef Threading_h 30 #ifndef Threading_h
31 #define Threading_h 31 #define Threading_h
32 32
33 #include "wtf/Atomics.h"
34 #include "wtf/TypeTraits.h"
33 #include "wtf/WTFExport.h" 35 #include "wtf/WTFExport.h"
34 #include <stdint.h> 36 #include <stdint.h>
35 37
36 // For portability, we do not use thread-safe statics natively supported by some compilers (e.g. gcc). 38 // For portability, we do not make use of C++11 thread-safe statics, as supporte d
37 #define AtomicallyInitializedStatic(T, name) \ 39 // by some toolchains.
38 WTF::lockAtomicallyInitializedStaticMutex(); \ 40 #define AtomicallyInitializedStaticReference(T, name, initializer) \
39 static T name; \ 41 /* Double-checked locking; init to nullptr is thread-safe on all implementat ions. */ \
40 WTF::unlockAtomicallyInitializedStaticMutex(); 42 static WTF::RemoveConst<T>::Type* name##_pointer = nullptr; \
haraken 2015/01/21 15:23:33 _pointer => Pointer
sof 2015/01/21 15:51:38 Thanks, switched.
43 if (!WTF::acquireLoad(reinterpret_cast<void* const*>(&name##_pointer))) { \
44 WTF::lockAtomicallyInitializedStaticMutex(); \
45 if (!WTF::acquireLoad(reinterpret_cast<void* const*>(&name##_pointer))) \
46 WTF::releaseStore(reinterpret_cast<void**>(&name##_pointer), initial izer); \
47 WTF::unlockAtomicallyInitializedStaticMutex(); \
48 } \
49 T& name = *name##_pointer
41 50
42 namespace WTF { 51 namespace WTF {
43 52
44 #if OS(WIN) 53 #if OS(WIN)
45 typedef uint32_t ThreadIdentifier; 54 typedef uint32_t ThreadIdentifier;
46 #else 55 #else
47 typedef intptr_t ThreadIdentifier; 56 typedef intptr_t ThreadIdentifier;
48 #endif 57 #endif
49 58
50 WTF_EXPORT ThreadIdentifier currentThread(); 59 WTF_EXPORT ThreadIdentifier currentThread();
51 60
52 WTF_EXPORT void lockAtomicallyInitializedStaticMutex(); 61 WTF_EXPORT void lockAtomicallyInitializedStaticMutex();
53 WTF_EXPORT void unlockAtomicallyInitializedStaticMutex(); 62 WTF_EXPORT void unlockAtomicallyInitializedStaticMutex();
54 63
55 } // namespace WTF 64 } // namespace WTF
56 65
57 using WTF::ThreadIdentifier; 66 using WTF::ThreadIdentifier;
58 using WTF::currentThread; 67 using WTF::currentThread;
59 68
60 #endif // Threading_h 69 #endif // Threading_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698