Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 794213002: Fix builds w/ component=="shared_library" and v8_use_external_startup_data==1. (Closed)

Created:
6 years ago by vogelheim
Modified:
6 years ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix builds w/ component=="shared_library" and v8_use_external_startup_data==1. R=machenbach@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M test/cctest/cctest.gyp View 1 chunk +7 lines, -6 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vogelheim
6 years ago (2014-12-11 14:17:54 UTC) #1
Michael Achenbach
lgtm (rubber stamp)
6 years ago (2014-12-11 15:04:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794213002/1
6 years ago (2014-12-11 16:14:13 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-11 16:41:56 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698