Issue 794203003: [turbofan] Second round of optimisation for unordered comparisons on arm/arm64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 794203003: [turbofan] Second round of optimisation for unordered comparisons on arm/arm64. (Closed)

Created:
6 years ago by baptiste.afsa1

Modified:
6 years ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Second round of optimisation for unordered comparisons on arm/arm64. Avoid explicitly branching to the false label on unordered when the condition on the true branch will not catch the unordered case and let the code fall through. R=bmeurer@chromium.org

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -12 lines)			Patch
	M	src/compiler/arm/code-generator-arm.cc	View		3 chunks	+9 lines, -6 lines	0 comments	Download
	M	src/compiler/arm64/code-generator-arm64.cc	View		3 chunks	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794203003/1

6 years ago (2014-12-11 17:24:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages