Issue 7942010: Replacing movntq instruction with movq for 874 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7942010: Replacing movntq instruction with movq for 874 branch. (Closed)

Created:
9 years, 3 months ago by scherkus (not reviewing)

Modified:
9 years, 3 months ago

Reviewers:
karen, Ami GONE FROM CHROMIUM, Alpha Left Google

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/branches/874/src/

Visibility:
Public.

Description

Replacing movntq instruction with movq for 874 branch. There's a slight perf hit of 400-800us on a 1080p frame that will be addressed by doing runtime CPU detection in the next release of Chrome. BUG=97151 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101889

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -2 lines)			Patch
	M	media/base/yuv_row_posix.cc	View		8 chunks	+27 lines, -1 line	0 comments	Download
	M	media/base/yuv_row_win.cc	View		9 chunks	+31 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

fischman: review please sir hclam: FYI -- hopefully you finish up all the assembly reorganizing ...

9 years, 3 months ago (2011-09-19 21:21:43 UTC) #1

Ami GONE FROM CHROMIUM

LGTM If it was me I'd #define movntq movq for the win version and #define ...

9 years, 3 months ago (2011-09-19 21:27:51 UTC) #2

+karen for branch modification request

Expand Messages | Collapse Messages