Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 7942006: Merge 95012 - [chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge. (Closed)

Created:
7 years, 9 months ago by levin
Modified:
7 years, 9 months ago
Reviewers:
levin
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 95012 - [chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge. https://bugs.webkit.org/show_bug.cgi?id=67943 Reviewed by Adam Barth. * src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess allowing the automatic ref counting to work. This was previous needed when the ref counting wasn't working but that was fixed in r94986. Note that the design was to have ref counting since the methods take PassRefPtr and the class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when adding in AllowCrossThreadAccess.) (WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::didWrite): (WebKit::WorkerFileWriterCallbacksBridge::didFail): (WebKit::WorkerFileWriterCallbacksBridge::didTruncate): (WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread): TBR=levin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp View 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
levin
7 years, 9 months ago (2011-09-19 20:20:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698