components/password_manager/core/browser/password_manager.cc - Issue 794133002: [Password Manager] Add UMA signals to understand how often the password form submit navigate…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 794133002: [Password Manager] Add UMA signals to understand how often the password form submit navigate… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/chrome_password_manager_client.cc ('K') | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | components/password_manager/core/browser/password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index d4694cc6e71f15bbb19d203ef398b10e45bf414a..dbf33491e033858f8bc225d2596b922a14a17732 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -397,6 +397,7 @@ void PasswordManager::OnPasswordFormsParsed(

password_manager::PasswordManagerDriver* driver,

const std::vector<PasswordForm>& forms) {

CreatePendingLoginManagers(driver, forms);

+ client_->OnPasswordFormsParsed();

}

void PasswordManager::CreatePendingLoginManagers(