[Password Manager] Add UMA signals to understand how often the password form submit navigate…

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
@@ skipping 25 matching lines @@
 #include "components/password_manager/core/browser/log_receiver.h"
 #include "components/password_manager/core/browser/password_form_manager.h"
 #include "components/password_manager/core/browser/password_manager_internals_service.h"
 #include "components/password_manager/core/browser/password_manager_metrics_util.h"
 #include "components/password_manager/core/browser/password_manager_url_collection_experiment.h"
 #include "components/password_manager/core/common/password_manager_switches.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "google_apis/gaia/gaia_urls.h"
+#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "net/base/url_util.h"
 #include "third_party/re2/re2/re2.h"
 
 #if defined(OS_ANDROID)
 #include "chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.h"
 #endif
 
 namespace {
 
 void ReportOsPassword() {
   password_manager_util::OsPasswordStatus status =
       password_manager_util::GetOsPasswordStatus();
 
   UMA_HISTOGRAM_ENUMERATION("PasswordManager.OsPasswordStatus",
                             status,
                             password_manager_util::MAX_PASSWORD_STATUS);
 }
 
+// Helper function to capture the UMA matriculations for instances where
+// submitting a password |login_form| navigates to the different domain/host or
+// not.
+void LogFormSubmitNavigateToDifferentDomain(

[vabr (Chromium), 2014/12/11 12:31:33]

nit: Log->Report (logging is usually used in the debug sense of the word, while
UMA metrics are reported, recorded, or just sent).
Further, the name suggests that the navigation was to a different domain (while
it should name the question about that). So what about

RecordWhetherTargetDomainDiffers

[Pritam Nikam, 2014/12/12 14:30:08]

Done.

+    const autofill::PasswordForm& login_form) {
+  bool navigates_to_different_domain =
+      !net::registry_controlled_domains::SameDomainOrHost(
+          login_form.origin, login_form.action,
+          net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES);
+  UMA_HISTOGRAM_BOOLEAN("PasswordManager.SubmitNavigatesToDifferentDomain",
+                        navigates_to_different_domain);
+}
+
 }  // namespace
 
 using password_manager::ContentPasswordManagerDriverFactory;
 using password_manager::PasswordManagerInternalsService;
 using password_manager::PasswordManagerInternalsServiceFactory;
 
 DEFINE_WEB_CONTENTS_USER_DATA_KEY(ChromePasswordManagerClient);
 
 // Shorten the name to spare line breaks. The code provides enough context
 // already.
@@ skipping 129 matching lines @@
 
 bool ChromePasswordManagerClient::PromptUserToSavePassword(
     scoped_ptr<password_manager::PasswordFormManager> form_to_save) {
   // Save password infobar and the password bubble prompts in case of
   // "webby" URLs and do not prompt in case of "non-webby" URLS (e.g. file://).
   if (!BrowsingDataHelper::IsWebScheme(
       web_contents()->GetLastCommittedURL().scheme())) {
     return false;
   }
 
+  // Capture the UMA stats to get to know the volume and frequency for

[vabr (Chromium), 2014/12/11 12:31:33]

I don't think this comment is necessary. We always use UMA to "get to know the
volume and frequency" :), and the rest is covered by the method name.

[Pritam Nikam, 2014/12/12 14:30:08]

Done.

+  // occurences where submiting the password login form lands to different
+  // domain.
+  LogFormSubmitNavigateToDifferentDomain(form_to_save->observed_form());
+
   if (IsTheHotNewBubbleUIEnabled()) {
     ManagePasswordsUIController* manage_passwords_ui_controller =
         ManagePasswordsUIController::FromWebContents(web_contents());
     manage_passwords_ui_controller->OnPasswordSubmitted(form_to_save.Pass());
   } else {
     std::string uma_histogram_suffix(
         password_manager::metrics_util::GroupIdToString(
             password_manager::metrics_util::MonitoredDomainGroupId(
                 form_to_save->realm(), GetPrefs())));
     SavePasswordInfoBarDelegate::Create(
@@ skipping 350 matching lines @@
 
   if (group_name == "DisallowSyncCredentialsForReauth") {
     autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS_FOR_REAUTH;
   } else if (group_name == "DisallowSyncCredentials") {
       autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS;
   } else {
     // Allow by default.
     autofill_sync_state_ = ALLOW_SYNC_CREDENTIALS;
   }
 }