Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 794123003: Do not calculate the same gradient length for every color stops. (Closed)

Created:
6 years ago by reni
Modified:
5 years, 11 months ago
Reviewers:
Timothy Loh, Mike West
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis, Mike West
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Do not calculate the same gradient length for every color stops. The value of |gradientLength| in blink::CSSGradientValue::addStops only depends on |gradientStart| and |gradientEnd| which values don't change after their initializations, so |gradientLength| won't either. In spite of this, the |gradientLength| is computed for every color stops because |computedGradientLength| - the variable that was originally introduced to check if |gradientLength| was set already - is never changed to true. The patch supplies this missing switch. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/css/CSSGradientValue.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
reni
The failing bots seem to be unrelated to the change.
6 years ago (2014-12-15 17:10:07 UTC) #1
reni
Could someone take a look at this, please?
5 years, 11 months ago (2015-01-07 14:18:04 UTC) #3
Mike West
LGTM.
5 years, 11 months ago (2015-01-12 14:17:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794123003/1
5 years, 11 months ago (2015-01-12 14:54:24 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 15:25:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188224

Powered by Google App Engine
This is Rietveld 408576698