Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 794113002: [turbofan] Fix typing of typed array loads/stores. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -109 lines) Patch
M src/compiler/js-typed-lowering.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M src/compiler/typer.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/compiler/typer.cc View 6 chunks +102 lines, -96 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years ago (2014-12-11 09:14:49 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-11 09:21:25 UTC) #3
Benedikt Meurer
6 years ago (2014-12-11 09:31:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2bfe09a60716a7def13386a8f3a92103d7fa6797 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698