Issue 7941003: Add base dependency since omx_video_decode_accelerator_unittest depends on base/.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7941003: Add base dependency since omx_video_decode_accelerator_unittest depends on base/. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 8 months ago by sadrul

Modified:
3 years, 8 months ago

Reviewers:
kliegs, Ami GONE FROM CHROMIUM

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add base dependency since omx_video_decode_accelerator_unittest depends on base/. BUG=chromium-os:20592 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101757

Patch Set 1 #

Total comments: 1

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	content/content_tests.gypi	View		1 chunk	+1 line, -0 lines	1 comment	Download

Trybot results: linux_touch linux win mac linux_chromeos

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

lgtm http://codereview.chromium.org/7941003/diff/1/content/content_tests.gypi File content/content_tests.gypi (right): http://codereview.chromium.org/7941003/diff/1/content/content_tests.gypi#newcode192 content/content_tests.gypi:192: '../base/base.gyp:base', sort by moving below content (consistent with ...

3 years, 8 months ago (2011-09-19 16:39:43 UTC) #2

kliegs

3 years, 8 months ago (2011-09-19 16:44:21 UTC) #3

As a test I emerged with USE=touchui on tegra2 and it failed prior to this
patch.  Applying the change and rebuilding worked so this fixed the problem.

Expand Messages | Collapse Messages