Page context menu accelerator "S" is used twice.

Page context menu accelerator "S" is used twice.

After selecting text in textbox. right click make context menu to
came, then selecting 'S' it switchs focus highlight between
'Spell-checker options' and 'Search Google for "..."
as both have 'S' as associated key.

Have made "O" for spell-checker options and "S" for Search.

BUG=226234
Committed: https://crrev.com/d426a1cd0b28166efb8df06b129152e2e0568904
Cr-Commit-Position: refs/heads/master@{#308039}

[Deepak, 2014-12-11 09:59:38]

deepak.m1@samsung.com changed reviewers:
+ cpu@chromium.org

[Deepak, 2014-12-11 09:59:40]

PTAL

[cpu_(ooo_6.6-7.5), 2014-12-11 20:41:46]

cpu@chromium.org changed reviewers:
+ pkasting@chromium.org

[cpu_(ooo_6.6-7.5), 2014-12-11 20:41:46]

I see the issue you are trying to fix, however I don't see the accelerator marks
(underlines) in the context menu, that negates the usefulness of them or even
the need to fix this.

I see them for the wrench menu if I use 'alt' + enter to open them, but I don't
see them in any case for the context menu, they should be shown from the 'menu'
key which is the one on the right side of the right windows key.

Peter, any clue about this? is this a bug?

[Peter Kasting, 2014-12-11 20:53:45]

On 2014/12/11 20:41:46, cpu wrote:
> I see the issue you are trying to fix, however I don't see the accelerator
marks
> (underlines) in the context menu, that negates the usefulness of them or even
> the need to fix this.
> 
> I see them for the wrench menu if I use 'alt' + enter to open them, but I
don't
> see them in any case for the context menu, they should be shown from the
'menu'
> key which is the one on the right side of the right windows key.
> 
> Peter, any clue about this? is this a bug?

It's a Windows accessibility setting whether to show the underlines.  The
setting is off by default, you have to toggle it on.

[Peter Kasting, 2014-12-11 20:54:26]

LGTM

[Deepak, 2014-12-12 01:23:42]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2014-12-12 01:25:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/794093004/1

[commit-bot: I haz the power, 2014-12-12 02:59:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-12 03:00:42]

Patchset 1 (id:??) landed as
https://crrev.com/d426a1cd0b28166efb8df06b129152e2e0568904
Cr-Commit-Position: refs/heads/master@{#308039}