Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 794083002: Fix left out WeakPtrFactory member ordering in content (Closed)

Created:
6 years ago by anujsharma
Modified:
6 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, dmichael (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member ordering in content Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/16fa4dfb291f54073d34d5191339168dcb808ddb Cr-Commit-Position: refs/heads/master@{#307915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
6 years ago (2014-12-11 09:50:20 UTC) #2
Avi (use Gerrit)
lgtm
6 years ago (2014-12-11 15:01:38 UTC) #3
anujsharma
On 2014/12/11 15:01:38, Avi wrote: > lgtm Thanks Avi for lgtm.
6 years ago (2014-12-11 16:16:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794083002/1
6 years ago (2014-12-11 16:17:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-11 17:04:52 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-11 17:05:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16fa4dfb291f54073d34d5191339168dcb808ddb
Cr-Commit-Position: refs/heads/master@{#307915}

Powered by Google App Engine
This is Rietveld 408576698