Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: extensions/common/api/sockets/sockets_manifest_permission_unittest.cc

Issue 794063002: Removed duplicate code from Socket permission messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_patch_2
Patch Set: Test namespace fix Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/sockets/sockets_manifest_permission_unittest.cc
diff --git a/extensions/common/api/sockets/sockets_manifest_permission_unittest.cc b/extensions/common/api/sockets/sockets_manifest_permission_unittest.cc
index 6c96fb21b673059b7d89aca7ba529b52be67b999..419ddd77aecfb8e5390573f966ceca568bfc7718 100644
--- a/extensions/common/api/sockets/sockets_manifest_permission_unittest.cc
+++ b/extensions/common/api/sockets/sockets_manifest_permission_unittest.cc
@@ -97,10 +97,9 @@ static testing::AssertionResult CheckFormat(
// Note: We use multiset because SocketsManifestPermission does not have to
// store entries in the order found in the json message.
std::multiset<CheckFormatEntry> parsed_permissions;
- for (SocketsManifestPermission::SocketPermissionEntrySet::const_iterator it =
+ for (SocketPermissionEntrySet::const_iterator it =
permission->entries().begin();
- it != permission->entries().end();
- ++it) {
+ it != permission->entries().end(); ++it) {
parsed_permissions.insert(
CheckFormatEntry(it->pattern().type, it->GetHostPatternAsString()));
}
« no previous file with comments | « extensions/common/api/sockets/sockets_manifest_permission.cc ('k') | extensions/common/permissions/socket_permission.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698