Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 794063002: Removed duplicate code from Socket permission messages (Closed)

Created:
6 years ago by sashab
Modified:
6 years ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@permissions_patch_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed duplicate code from Socket permission messages Removed the permission message generating code that was duplicated across SocketPermission and SocketManifestPermission and combined it into a single static function in SocketManifestPermission. Based on crrev.com/795543002. BUG=398257 Committed: https://crrev.com/2915a685c80ce8a5e5eed9e9662a57e16936bca3 Cr-Commit-Position: refs/heads/master@{#309517}

Patch Set 1 #

Patch Set 2 : Changed iterator loops to for-each loops #

Total comments: 4

Patch Set 3 : Review feedback #

Patch Set 4 : Rebase #

Patch Set 5 : Test namespace fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -231 lines) Patch
M extensions/common/api/sockets/sockets_manifest_permission.h View 1 2 2 chunks +7 lines, -16 lines 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission.cc View 1 4 chunks +133 lines, -117 lines 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission_unittest.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/common/permissions/socket_permission.cc View 2 chunks +21 lines, -95 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sashab
It turns out the code for generating permissions in both socket files is exactly the ...
6 years ago (2014-12-11 04:19:40 UTC) #2
Yoyo Zhou
LGTM, looks simple enough. https://codereview.chromium.org/794063002/diff/20001/extensions/common/api/sockets/sockets_manifest_permission.h File extensions/common/api/sockets/sockets_manifest_permission.h (right): https://codereview.chromium.org/794063002/diff/20001/extensions/common/api/sockets/sockets_manifest_permission.h#newcode25 extensions/common/api/sockets/sockets_manifest_permission.h:25: typedef std::set<SocketPermissionEntry> SocketPermissionEntrySet; nit: newline ...
6 years ago (2014-12-13 02:38:49 UTC) #3
sashab
https://codereview.chromium.org/794063002/diff/20001/extensions/common/api/sockets/sockets_manifest_permission.h File extensions/common/api/sockets/sockets_manifest_permission.h (right): https://codereview.chromium.org/794063002/diff/20001/extensions/common/api/sockets/sockets_manifest_permission.h#newcode25 extensions/common/api/sockets/sockets_manifest_permission.h:25: typedef std::set<SocketPermissionEntry> SocketPermissionEntrySet; On 2014/12/13 02:38:49, Yoyo Zhou wrote: ...
6 years ago (2014-12-14 22:54:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794063002/80001
6 years ago (2014-12-23 01:21:15 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years ago (2014-12-23 02:07:13 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-23 02:08:16 UTC) #8
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/2915a685c80ce8a5e5eed9e9662a57e16936bca3
Cr-Commit-Position: refs/heads/master@{#309517}

Powered by Google App Engine
This is Rietveld 408576698