Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 794053007: Revert of Fix GN build on Linux ChromiumOS (Closed)

Created:
5 years, 11 months ago by nhiroki
Modified:
5 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix GN build on Linux ChromiumOS (patchset #1 id:1 of https://codereview.chromium.org/816393003/) Reason for revert: This broke the GN compile on chromeos: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20GN&number=5300 Original issue's description: > Fix GN build on Linux ChromiumOS > > This is a fix for Linux ChromiumOS GN build: > http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/5292 > > "view_event_test_platform_part_ash.cc" is not in 'sources'. > > BUG=n/a > TEST=build > TBR=brettw@chromium.org > NOTRY=true > > Committed: https://crrev.com/45dcea9064c39161b112b1810e78de13b044e991 > Cr-Commit-Position: refs/heads/master@{#310050} TBR=brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG=n/a Committed: https://crrev.com/7a2071d1d2a1b7aafb5fbba3b802100d2a3661e8 Cr-Commit-Position: refs/heads/master@{#310053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nhiroki
Created Revert of Fix GN build on Linux ChromiumOS
5 years, 11 months ago (2015-01-06 04:48:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794053007/1
5 years, 11 months ago (2015-01-06 04:49:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 04:50:02 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 04:50:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a2071d1d2a1b7aafb5fbba3b802100d2a3661e8
Cr-Commit-Position: refs/heads/master@{#310053}

Powered by Google App Engine
This is Rietveld 408576698