Issue 794053003: Revert of Call DisableInlineAllocation() in heap setup when flag inline_new is off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 794053003: Revert of Call DisableInlineAllocation() in heap setup when flag inline_new is off. (Closed)

Created:
6 years ago by Hannes Payer (out of office)

Modified:
6 years ago

Reviewers:
ulan, Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Revert of Call DisableInlineAllocation() in heap setup when flag inline_new is off. (patchset #1 id:1 of https://codereview.chromium.org/790353006/) Reason for revert: Fix Windows nosnap. Original issue's description: > Call DisableInlineAllocation() in heap setup when flag inline_new is off. > > BUG= TBR=ulan@chromium.org,mstarzinger@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/286748c97b721e1bbe540e26f117275bb722e5dd Cr-Commit-Position: refs/heads/master@{#25815}

Created: 6 years ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	src/heap/heap.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Hannes Payer (out of office)

Created Revert of Call DisableInlineAllocation() in heap setup when flag inline_new is off.

6 years ago (2014-12-15 11:38:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794053003/1

6 years ago (2014-12-15 11:39:14 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-17 10:13:14 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/286748c97b721e1bbe540e26f117275bb722e5dd
Cr-Commit-Position: refs/heads/master@{#25815}