src/compiler/js-typed-lowering.cc - Issue 794013004: [turbofan] Correctify lowering of Uint8ClampedArray buffer access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 794013004: [turbofan] Correctify lowering of Uint8ClampedArray buffer access. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix typed lowering. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/js-typed-lowering.cc

diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc

index f5bb09d1b2016927404848c609d8a0683302614a..2338866d6d2274830dff5b132128ca3f9216659b 100644

--- a/src/compiler/js-typed-lowering.cc

+++ b/src/compiler/js-typed-lowering.cc

@@ -781,7 +781,6 @@ Reduction JSTypedLowering::ReduceJSLoadProperty(Node* node) {

double const byte_length = array->byte_length()->Number();

CHECK_LT(k, arraysize(shifted_int32_ranges_));

if (IsExternalArrayElementsKind(array->map()->elements_kind()) &&

- access.external_array_type() != kExternalUint8ClampedArray &&

key_type->Is(shifted_int32_ranges_[k]) && byte_length <= kMaxInt) {

// JSLoadProperty(typed-array, int32)

Handle<ExternalArray> elements =

« no previous file with comments | « no previous file | src/compiler/simplified-operator.cc » ('j') | no next file with comments »