Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 794013004: [turbofan] Correctify lowering of Uint8ClampedArray buffer access. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Correctify lowering of Uint8ClampedArray buffer access. TEST=mjsunit/compiler/regress-444508.js BUG=chromium:444508 LOG=y R=machenbach@chromium.org Committed: https://crrev.com/65e69497abe207f5c06d7923632b7d10541bb35b Cr-Commit-Position: refs/heads/master@{#25916}

Patch Set 1 #

Patch Set 2 : Fix typed lowering. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +1 line, -2 lines 0 comments Download
A test/mjsunit/compiler/regress-444508.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL
6 years ago (2014-12-22 08:08:59 UTC) #2
Michael Achenbach
lgtm (rubber stamp)
6 years ago (2014-12-22 08:27:22 UTC) #3
Benedikt Meurer
Committed patchset #2 (id:20001) manually as 65e69497abe207f5c06d7923632b7d10541bb35b (presubmit successful).
6 years ago (2014-12-22 08:28:07 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-22 08:28:10 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65e69497abe207f5c06d7923632b7d10541bb35b
Cr-Commit-Position: refs/heads/master@{#25916}

Powered by Google App Engine
This is Rietveld 408576698