Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 794013002: [ServiceWorker] Re-enable service_worker.service_worker perf test. (Closed)

Created:
6 years ago by horo
Modified:
6 years ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Re-enable service_worker.service_worker perf test. This test was disabled because of the lack of avconv in the try bots. BUG=433943 Committed: https://crrev.com/78e4cdcf2b533033c14e342e5d83440d3b5e749e Cr-Commit-Position: refs/heads/master@{#307851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/benchmarks/service_worker.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
horo
tonyg@ Could you please review this?
6 years ago (2014-12-11 01:30:25 UTC) #2
tonyg
lgtm
6 years ago (2014-12-11 02:10:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794013002/1
6 years ago (2014-12-11 02:15:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-11 03:32:30 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78e4cdcf2b533033c14e342e5d83440d3b5e749e Cr-Commit-Position: refs/heads/master@{#307851}
6 years ago (2014-12-11 03:33:11 UTC) #7
oystein (OOO til 10th of July)
5 years, 10 months ago (2015-02-03 04:25:58 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/883013005/ by oysteine@chromium.org.

The reason for reverting is: Still flaky on Mac.

Powered by Google App Engine
This is Rietveld 408576698