Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 793983003: Rewrite broken Facebook test case in top_7_stress (Closed)

Created:
6 years ago by hashimoto
Modified:
5 years, 12 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite broken Facebook test case in top_7_stress To enable memory.top_7_stress benchmark. BUG=440305 TEST=tools/perf/run_benchmark memory.top_7_stress Committed: https://crrev.com/9a5f241dcf8825d10ac1f43bda60ddd17760f044 Cr-Commit-Position: refs/heads/master@{#309340}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : record_wpr #

Patch Set 4 : Add top_7_stress.json instead of changing top_25.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -13 lines) Patch
M tools/perf/benchmarks/memory.py View 1 chunk +0 lines, -1 line 0 comments Download
A tools/perf/page_sets/data/top_7_stress.json View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A + tools/perf/page_sets/data/top_7_stress_000.wpr.sha1 View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/top_7_stress_001.wpr.sha1 View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/perf/page_sets/data/top_7_stress_002.wpr.sha1 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/top_7_stress.py View 1 2 3 3 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
hashimoto
Currently, Facebook test case is failing because action_runner.ClickElement(text='About') results in a 404 being served (maybe ...
6 years ago (2014-12-11 12:10:04 UTC) #2
tonyg
Wouldn't we need to re-record the pageset along with this change?
6 years ago (2014-12-13 01:05:00 UTC) #3
hashimoto
On 2014/12/13 01:05:00, tonyg wrote: > Wouldn't we need to re-record the pageset along with ...
6 years ago (2014-12-15 04:39:23 UTC) #4
tonyg
On 2014/12/15 04:39:23, hashimoto wrote: > On 2014/12/13 01:05:00, tonyg wrote: > > Wouldn't we ...
6 years ago (2014-12-16 02:55:40 UTC) #5
hashimoto
On 2014/12/16 02:55:40, tonyg wrote: > On 2014/12/15 04:39:23, hashimoto wrote: > > On 2014/12/13 ...
6 years ago (2014-12-16 07:10:32 UTC) #6
hashimoto
Found that changing top_25.json results in breaking smoothness.top_25_smooth because it's sharing the same wpr with ...
6 years ago (2014-12-16 08:32:33 UTC) #7
hashimoto
Tony, could you take a look at this CL?
6 years ago (2014-12-19 06:46:02 UTC) #8
tonyg
lgtm
6 years ago (2014-12-19 18:07:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793983003/60001
6 years ago (2014-12-20 03:47:06 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-20 05:36:23 UTC) #12
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/9a5f241dcf8825d10ac1f43bda60ddd17760f044 Cr-Commit-Position: refs/heads/master@{#309340}
6 years ago (2014-12-20 05:37:11 UTC) #13
tonyg
5 years, 12 months ago (2014-12-21 19:32:22 UTC) #14
Message was sent while issue was closed.
On 2014/12/20 05:37:11, I haz the power (commit-bot) wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/9a5f241dcf8825d10ac1f43bda60ddd17760f044
> Cr-Commit-Position: refs/heads/master@{#309340}

Looks like this is failing on the bots, but it can't be automatically reverted
on the bots because they don't know how to revert A+ files. So I'm quickly
disabling it here: https://codereview.chromium.org/810333004

Powered by Google App Engine
This is Rietveld 408576698