Issue 793973004: Fix media::MojoRendererTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 793973004: Fix media::MojoRendererTest. (Closed)

Created:
6 years ago by xhwang

Modified:
6 years ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix media::MojoRendererTest. Now we have real decoders abailable so MojoRendererImpl::Initialize() should succeed. Committed: https://crrev.com/eb0c87bd58fa569731c96feef633c4a5b4075cee Cr-Commit-Position: refs/heads/master@{#308475}

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	media/mojo/services/media_renderer_apptest.cc	View		2 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

xhwang

I thought I ran it not too long ago and it's working. But apparently this ...

6 years ago (2014-12-15 23:17:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793973004/1

6 years ago (2014-12-15 23:29:56 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-16 00:37:14 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/eb0c87bd58fa569731c96feef633c4a5b4075cee
Cr-Commit-Position: refs/heads/master@{#308475}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages