chromeos: Add separate screen dim/off delays for lock screen

chromeos: Add separate screen dim/off delays for lock screen

Add power.lock_screen_dim_delay_ms and
power.lock_screen_off_delay_ms prefs that provide alternate
screen-dim and screen-off inactivity delays that are honored
while the screen is locked. They currently default to 30 and
40 seconds, respectively.

BUG=190499
Committed: https://crrev.com/da6705ff33881322561d1de86b4b221fde6498b2
Cr-Commit-Position: refs/heads/master@{#308131}

[Daniel Erat, 2014-12-11 00:26:33]

derat@chromium.org changed reviewers:
+ bartfab@chromium.org

[Daniel Erat, 2014-12-11 00:26:33]

i need to test this on a real device still, but i figured i'd run the general
approach by you.

https://codereview.chromium.org/793973002/diff/1/chrome/browser/chromeos/powe...
File chrome/browser/chromeos/power/power_prefs_unittest.cc (right):

https://codereview.chromium.org/793973002/diff/1/chrome/browser/chromeos/powe...
chrome/browser/chromeos/power/power_prefs_unittest.cc:179:
EXPECT_EQ(GetExpectedPowerPolicyForProfile(login_profile, false),
i suspect that you'll ask me to comment all of these boolean arguments, which
will make me sad since the lines will wrap. :-)

[bartfab (slow), 2014-12-12 12:22:37]

lgtm

https://codereview.chromium.org/793973002/diff/1/chrome/browser/chromeos/powe...
File chrome/browser/chromeos/power/power_prefs_unittest.cc (right):

https://codereview.chromium.org/793973002/diff/1/chrome/browser/chromeos/powe...
chrome/browser/chromeos/power/power_prefs_unittest.cc:179:
EXPECT_EQ(GetExpectedPowerPolicyForProfile(login_profile, false),
On 2014/12/11 00:26:33, Daniel Erat wrote:
> i suspect that you'll ask me to comment all of these boolean arguments, which
> will make me sad since the lines will wrap. :-)

Well, there are many simple ways around it:

1) Use a temporary, e.g.:
const bool screen_locked = false;
EXPECT_EQ(GetExpectedPowerPolicyForProfile(login_profile, screen_locked));
2) Add two aptly named wrappers around GetExpectedPowerPolicyForProfile().
3) Switch from a bool to an enum with values like |LOCKED| and |UNLOCKED|.

[Daniel Erat, 2014-12-12 17:36:39]

thanks, i'd considered the second and third ideas. i've gone ahead with the
third one (adding a one-off enum for this).

[Daniel Erat, 2014-12-12 17:38:18]

https://codereview.chromium.org/793973002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/power/power_prefs_unittest.cc (right):

https://codereview.chromium.org/793973002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/power/power_prefs_unittest.cc:109: screen_lock_state ==
LOCKED ? prefs::kPowerLockScreenDimDelayMs
weird (to my eyes) formatting is courtesy of clang-format.

[Daniel Erat, 2014-12-12 17:38:21]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-12-12 17:38:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/793973002/20001

[commit-bot: I haz the power, 2014-12-12 18:52:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-12 18:53:32]

Patchset 2 (id:??) landed as
https://crrev.com/da6705ff33881322561d1de86b4b221fde6498b2
Cr-Commit-Position: refs/heads/master@{#308131}