Allow chrome_shell_paks target to be reused

Allow chrome_shell_paks target to be reused

Currently, when multiple downstream targets depend on chrome_shell resource
paks, ninja outputs several warnings similar to:

ninja: warning: multiple rules generate ../assets/sample_apk/am.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate ../assets/sample_apk/ar.pak. builds involving this target will not be correct; continuing anyway

This commit refactors the pak copying logic into chrome_android_paks.gypi to
allow proper reuse of the target.

BUG=441011
Committed: https://crrev.com/bfca03a38e414405b50007e13c9e2c9cf3604049
Cr-Commit-Position: refs/heads/master@{#312960}

[davileen, 2014-12-11 00:12:26]

davileen@amazon.com changed reviewers:
+ aruslan@chromium.org

[davileen, 2014-12-11 00:14:31]

Hi aruslan,

This is a proposed fix for
https://code.google.com/p/chromium/issues/detail?id=441011

Let me know what you think!

Thanks,
David.

[davileen, 2015-01-02 22:15:51]

On 2014/12/11 00:14:31, davileen wrote:
> Hi aruslan,
> 
> This is a proposed fix for
> https://code.google.com/p/chromium/issues/detail?id=441011
> 
> Let me know what you think!
> 
> Thanks,
> David.

Hi aruslan,

Have you gotten a chance to look at this? Should I add a different reviewer?

David.

[davileen, 2015-01-05 19:35:55]

davileen@amazon.com changed reviewers:
+ newt@chromium.org

[davileen, 2015-01-05 19:47:48]

On 2015/01/02 22:15:51, davileen wrote:
> On 2014/12/11 00:14:31, davileen wrote:
> > Hi aruslan,
> > 
> > This is a proposed fix for
> > https://code.google.com/p/chromium/issues/detail?id=441011
> > 
> > Let me know what you think!
> > 
> > Thanks,
> > David.
> 
> Hi aruslan,
> 
> Have you gotten a chance to look at this? Should I add a different reviewer?
> 
> David.

Hi newt,

I've added you since I'm not sure aruslan is available. Please let me know what
you think.

David.

[davileen, 2015-01-14 23:45:05]

On 2015/01/05 19:47:48, davileen wrote:
> On 2015/01/02 22:15:51, davileen wrote:
> > On 2014/12/11 00:14:31, davileen wrote:
> > > Hi aruslan,
> > > 
> > > This is a proposed fix for
> > > https://code.google.com/p/chromium/issues/detail?id=441011
> > > 
> > > Let me know what you think!
> > > 
> > > Thanks,
> > > David.
> > 
> > Hi aruslan,
> > 
> > Have you gotten a chance to look at this? Should I add a different reviewer?
> > 
> > David.
> 
> Hi newt,
> 
> I've added you since I'm not sure aruslan is available. Please let me know
what
> you think.
> 
> David.

Any thoughts?

[newt (away), 2015-01-20 18:15:53]

https://codereview.chromium.org/793943004/diff/1/chrome/chrome_android_paks.gypi
File chrome/chrome_android_paks.gypi (right):

https://codereview.chromium.org/793943004/diff/1/chrome/chrome_android_paks.g...
chrome/chrome_android_paks.gypi:126: 'target_name': 'chrome_shell_paks_copy',
I'd call this "chrome_android_paks_copy", since this can now be depended on by
targets other than Chrome Shell.

[davileen, 2015-01-20 18:52:29]

On 2015/01/20 18:15:53, newt wrote:
>
https://codereview.chromium.org/793943004/diff/1/chrome/chrome_android_paks.gypi
> File chrome/chrome_android_paks.gypi (right):
> 
>
https://codereview.chromium.org/793943004/diff/1/chrome/chrome_android_paks.g...
> chrome/chrome_android_paks.gypi:126: 'target_name': 'chrome_shell_paks_copy',
> I'd call this "chrome_android_paks_copy", since this can now be depended on by
> targets other than Chrome Shell.

That makes sense.

[davileen, 2015-01-20 18:53:30]

PTAL

[davileen, 2015-01-22 22:34:34]

On 2015/01/20 18:53:30, davileen wrote:
> PTAL

I'm pinging this since I just found out about the new setting to have these
emails sent by Rietveld and not my amazon email. Hopefully this won't go to spam
:)

[newt (away), 2015-01-22 22:37:57]

lgtm.

[davileen, 2015-01-22 22:38:50]

The CQ bit was checked by davileen@amazon.com

[commit-bot: I haz the power, 2015-01-22 22:39:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/793943004/20001

[commit-bot: I haz the power, 2015-01-23 00:01:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 00:01:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davileen, 2015-01-23 00:07:56]

The CQ bit was checked by davileen@amazon.com

[commit-bot: I haz the power, 2015-01-23 00:12:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/793943004/20001

[commit-bot: I haz the power, 2015-01-23 00:15:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 00:15:14]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davileen, 2015-01-23 01:14:03]

The CQ bit was checked by davileen@amazon.com

[commit-bot: I haz the power, 2015-01-23 01:17:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/793943004/20001

[commit-bot: I haz the power, 2015-01-23 02:27:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 02:27:52]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/11...)

[davileen, 2015-01-23 02:42:35]

The CQ bit was checked by davileen@amazon.com

[commit-bot: I haz the power, 2015-01-23 02:43:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/793943004/20001

[davileen, 2015-01-23 18:44:25]

The CQ bit was unchecked by davileen@amazon.com

[davileen, 2015-01-23 18:44:28]

The CQ bit was checked by davileen@amazon.com

[commit-bot: I haz the power, 2015-01-23 18:45:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/793943004/20001

[commit-bot: I haz the power, 2015-01-23 23:22:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-23 23:24:15]

Patchset 2 (id:??) landed as
https://crrev.com/bfca03a38e414405b50007e13c9e2c9cf3604049
Cr-Commit-Position: refs/heads/master@{#312960}