Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 793933004: Remove dead StyleEngine::removeFontFaceRules. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
eseidel1
CC:
mojo-reviews_chromium.org, ojan, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove dead StyleEngine::removeFontFaceRules. This existed to support the incremental stylesheet updates (AnalyzedStyleUpdate) that sky doesn't support. R=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d22d99ca8a8e6fc7c44d998ae4c7a8ae645fd3b5

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M sky/engine/core/dom/StyleEngine.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
eseidel1
lgtm
6 years ago (2014-12-17 03:28:09 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years ago (2014-12-17 03:30:09 UTC) #5
esprehn
6 years ago (2014-12-18 05:54:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d22d99ca8a8e6fc7c44d998ae4c7a8ae645fd3b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698