Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 793933003: Add chrome:://device-log (Closed)

Created:
6 years ago by stevenjb
Modified:
6 years ago
Reviewers:
xiyuan, michaelpg
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome:://device-log This CL: * Adds a new chrome page, chrome://device-log for the device log UI * Eliminates the log from chrome://network, links to device-log BUG=293739 For browser_resources.grd: TBR=sky@chromium.org Committed: https://crrev.com/3803f86acc3c8477bce1e562c133a53ca149e8ff Cr-Commit-Position: refs/heads/master@{#308422}

Patch Set 1 #

Total comments: 40

Patch Set 2 : Feedback, localize network_ui #

Total comments: 12

Patch Set 3 : More Feedback + Move select options back to HTML #

Patch Set 4 : Remove unused function #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+547 lines, -242 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 4 1 chunk +55 lines, -11 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/browser/resources/chromeos/device_log_ui/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/chromeos/device_log_ui/device_log_ui.css View 1 1 chunk +115 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/device_log_ui/device_log_ui.html View 1 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/device_log_ui/device_log_ui.js View 1 1 chunk +149 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/network_ui/network_ui.css View 1 2 chunks +3 lines, -42 lines 0 comments Download
M chrome/browser/resources/chromeos/network_ui/network_ui.html View 1 2 3 4 3 chunks +18 lines, -29 lines 0 comments Download
M chrome/browser/resources/chromeos/network_ui/network_ui.js View 1 2 3 5 chunks +4 lines, -110 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/device_log_ui.h View 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/device_log_ui.cc View 1 1 chunk +88 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/network_ui.cc View 1 2 1 chunk +20 lines, -50 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M chromeos/device_event_log.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (6 generated)
stevenjb
6 years ago (2014-12-11 00:53:37 UTC) #2
michaelpg
Left some comments. https://codereview.chromium.org/793933003/diff/1/chrome/browser/resources/chromeos/device_log_ui/device_log_ui.css File chrome/browser/resources/chromeos/device_log_ui/device_log_ui.css (right): https://codereview.chromium.org/793933003/diff/1/chrome/browser/resources/chromeos/device_log_ui/device_log_ui.css#newcode29 chrome/browser/resources/chromeos/device_log_ui/device_log_ui.css:29: margin-right: 8px; -webkit-margin-end https://codereview.chromium.org/793933003/diff/1/chrome/browser/resources/chromeos/device_log_ui/device_log_ui.html File chrome/browser/resources/chromeos/device_log_ui/device_log_ui.html ...
6 years ago (2014-12-11 01:41:45 UTC) #3
xiyuan
https://codereview.chromium.org/793933003/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/793933003/diff/1/chrome/app/chromeos_strings.grdp#newcode5718 chrome/app/chromeos_strings.grdp:5718: For network logs, see: nit: This is not i18n ...
6 years ago (2014-12-11 04:36:09 UTC) #4
stevenjb
https://codereview.chromium.org/793933003/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/793933003/diff/1/chrome/app/chromeos_strings.grdp#newcode5718 chrome/app/chromeos_strings.grdp:5718: For network logs, see: On 2014/12/11 04:36:09, xiyuan wrote: ...
6 years ago (2014-12-11 19:57:52 UTC) #5
xiyuan
https://codereview.chromium.org/793933003/diff/20001/chrome/browser/resources/chromeos/network_ui/network_ui.html File chrome/browser/resources/chromeos/network_ui/network_ui.html (right): https://codereview.chromium.org/793933003/diff/20001/chrome/browser/resources/chromeos/network_ui/network_ui.html#newcode16 chrome/browser/resources/chromeos/network_ui/network_ui.html:16: <span i18n-values=".innerHTML: deviceLogLinkText"></span> nit: remove the space after ":". ...
6 years ago (2014-12-11 20:14:32 UTC) #6
stevenjb
https://codereview.chromium.org/793933003/diff/20001/chrome/browser/resources/chromeos/network_ui/network_ui.html File chrome/browser/resources/chromeos/network_ui/network_ui.html (right): https://codereview.chromium.org/793933003/diff/20001/chrome/browser/resources/chromeos/network_ui/network_ui.html#newcode16 chrome/browser/resources/chromeos/network_ui/network_ui.html:16: <span i18n-values=".innerHTML: deviceLogLinkText"></span> On 2014/12/11 20:14:32, xiyuan wrote: > ...
6 years ago (2014-12-11 20:53:14 UTC) #7
xiyuan
LGTM
6 years ago (2014-12-11 20:58:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793933003/60001
6 years ago (2014-12-11 23:08:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/17407)
6 years ago (2014-12-12 02:09:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793933003/60001
6 years ago (2014-12-15 17:12:39 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/18366)
6 years ago (2014-12-15 17:20:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793933003/80001
6 years ago (2014-12-15 20:23:27 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years ago (2014-12-15 21:31:41 UTC) #19
commit-bot: I haz the power
6 years ago (2014-12-15 21:32:40 UTC) #20
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/3803f86acc3c8477bce1e562c133a53ca149e8ff
Cr-Commit-Position: refs/heads/master@{#308422}

Powered by Google App Engine
This is Rietveld 408576698