Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 793913002: Stub implementation for PushRegistration.unregister(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@mvan_6
Patch Set: remove trace Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/push_messaging/unregister.html ('k') | Source/modules/modules.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/CallbackPromiseAdapter.h
diff --git a/Source/bindings/core/v8/CallbackPromiseAdapter.h b/Source/bindings/core/v8/CallbackPromiseAdapter.h
index fe80906915b64a31eafa6411104b5dd067222119..a6b525baeea61ec356aa440f89e917c0b6dff487 100644
--- a/Source/bindings/core/v8/CallbackPromiseAdapter.h
+++ b/Source/bindings/core/v8/CallbackPromiseAdapter.h
@@ -77,6 +77,7 @@ namespace blink {
// in and it is up to the callee to free the WebCallbacks instace.
template<typename S, typename T>
class CallbackPromiseAdapter final : public blink::WebCallbacks<typename S::WebType, typename T::WebType> {
+ WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
explicit CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver)
@@ -105,11 +106,11 @@ public:
private:
RefPtr<ScriptPromiseResolver> m_resolver;
- WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
};
template<typename T>
class CallbackPromiseAdapter<void, T> final : public blink::WebCallbacks<void, typename T::WebType> {
+ WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
explicit CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver)
@@ -136,11 +137,11 @@ public:
private:
RefPtr<ScriptPromiseResolver> m_resolver;
- WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
};
template<typename T>
class CallbackPromiseAdapter<bool, T> final : public blink::WebCallbacks<bool, typename T::WebType> {
+ WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
explicit CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver)
@@ -167,11 +168,11 @@ public:
private:
RefPtr<ScriptPromiseResolver> m_resolver;
- WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
};
template<>
class CallbackPromiseAdapter<void, void> final : public blink::WebCallbacks<void, void> {
+ WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
explicit CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver)
@@ -196,7 +197,35 @@ public:
private:
RefPtr<ScriptPromiseResolver> m_resolver;
+};
+
+template<>
+class CallbackPromiseAdapter<bool, void> final : public blink::WebCallbacks<bool, void> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
+public:
+ explicit CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)
+ : m_resolver(resolver)
+ {
+ ASSERT(m_resolver);
+ }
+ virtual ~CallbackPromiseAdapter() { }
+
+ virtual void onSuccess(bool* result) override
+ {
+ if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())
+ return;
+ m_resolver->resolve(*result);
+ }
+
+ virtual void onError() override
+ {
+ if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())
+ return;
+ m_resolver->reject();
+ }
+
+private:
+ RefPtr<ScriptPromiseResolver> m_resolver;
};
} // namespace blink
« no previous file with comments | « LayoutTests/http/tests/push_messaging/unregister.html ('k') | Source/modules/modules.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698