Stub implementation for PushRegistration.unregister().

Source/modules/push_messaging/PushRegistrationCallback.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PushRegistrationCallback_h
+#define PushRegistrationCallback_h
+
+#include "platform/heap/Handle.h"
+#include "public/platform/WebCallbacks.h"
+#include "wtf/Noncopyable.h"
+#include "wtf/PassRefPtr.h"
+#include "wtf/RefPtr.h"
+
+namespace blink {
+
+class ServiceWorkerRegistration;
+class ScriptPromiseResolver;
+struct WebPushError;
+struct WebPushRegistration;
+
+// PushRegistrationCallback is an implementation of WebPushRegistrationCallbacks
+// that will resolve the underlying promise depending on the result passed to
+// the callback. It takes a ServiceWorkerRegistration in its constructor and
+// will pass it to the PushRegistration.
+class PushRegistrationCallback final

[Michael van Ouwerkerk, 2014/12/12 12:18:04]

Please rename to PushRegistrationCallbacks. It's an awful name but I'd like to
be consistent with the WebCallbacks it inherits from.

[mlamouri (slow - plz ping), 2014/12/15 10:55:07]

Sic :(

+    : public WebCallbacks<WebPushRegistration, WebPushError> {

[Michael van Ouwerkerk, 2014/12/12 12:18:04]

Just write WebPushRegistrationCallbacks

[jochen (gone - plz use gerrit), 2014/12/12 14:26:12]

should be on previous line (no line length limit)

[mlamouri (slow - plz ping), 2014/12/15 10:55:07]

Hmm, I don't think so. It would require including WebPushProvider.h to get the
typedef.

+public:
+    explicit PushRegistrationCallback(PassRefPtr<ScriptPromiseResolver>, ServiceWorkerRegistration*);

[Michael van Ouwerkerk, 2014/12/12 12:18:04]

omit explicit as there are two arguments

[mlamouri (slow - plz ping), 2014/12/15 10:55:07]

Done.

+    virtual ~PushRegistrationCallback();

[Michael van Ouwerkerk, 2014/12/12 12:18:04]

Hmmz, I guess we should mark these with override instead of virtual.

[mlamouri (slow - plz ping), 2014/12/15 10:55:07]

Done.

+
+    void onSuccess(WebPushRegistration*) override;
+    void onError(WebPushError*) override;
+
+    void trace(Visitor*);
+
+private:
+    RefPtr<ScriptPromiseResolver> m_resolver;
+    Persistent<ServiceWorkerRegistration> m_registration;

[Michael van Ouwerkerk, 2014/12/12 12:18:04]

Please rename to m_serviceWorkerRegistration to distinguish from that other
registration.

[mlamouri (slow - plz ping), 2014/12/15 10:55:07]

Done.

+
+    WTF_MAKE_NONCOPYABLE(PushRegistrationCallback);
+};
+
+} // namespace blink
+
+#endif // PushRegistrationCallback_h