Stub implementation for PushRegistration.unregister().

Source/modules/push_messaging/PushRegistration.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PushRegistration_h
 #define PushRegistration_h
 
+#include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "platform/heap/Handle.h"
 #include "public/platform/WebPushRegistration.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
+class ServiceWorkerRegistration;
 class ScriptPromiseResolver;
+class ScriptState;
 
 class PushRegistration final : public GarbageCollectedFinalized<PushRegistration>, public ScriptWrappable {
     DEFINE_WRAPPERTYPEINFO();
 public:
     // For CallbackPromiseAdapter.
     typedef WebPushRegistration WebType;

[Michael van Ouwerkerk, 2014/12/12 12:18:04]

It seems you don't need this for CallbackPromiseAdapter anymore.

[mlamouri (slow - plz ping), 2014/12/15 10:55:07]

Done.

-    static PushRegistration* take(ScriptPromiseResolver*, WebType* registrationRaw);
+    static PushRegistration* take(ScriptPromiseResolver*, WebType* pushRegistration, ServiceWorkerRegistration*);
     static void dispose(WebType* registrationRaw);
 
     virtual ~PushRegistration();
 
     const String& pushEndpoint() const { return m_pushEndpoint; }
     const String& pushRegistrationId() const { return m_pushRegistrationId; }
+    ScriptPromise unregister(ScriptState*);
 
-    void trace(Visitor*) { }
+    void trace(Visitor*);
 
 private:
-    PushRegistration(const String& pushEndpoint, const String& pushRegistrationId);
+    PushRegistration(const String& pushEndpoint, const String& pushRegistrationId, ServiceWorkerRegistration*);
 
     String m_pushEndpoint;
     String m_pushRegistrationId;
+    Member<ServiceWorkerRegistration> m_registration;

[Michael van Ouwerkerk, 2014/12/12 12:18:04]

Please rename this to m_serviceWorkerRegistration to distinguish from |this|.

[mlamouri (slow - plz ping), 2014/12/15 10:55:07]

Done.

 };
 
 } // namespace blink
 
 #endif // PushRegistration_h