Chromium Code Reviews Chromium Code Reviews
Issue 793913002:
Stub implementation for PushRegistration.unregister(). (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@mvan_6| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html> | 2 <html> |
| 3 <head> | 3 <head> |
| 4 <title>register() is rejected when permission has been denied</title> | 4 <title>Test PushRegistration.unregister()</title> |
| 5 <link rel="manifest" href="resources/push_manifest.json"> | 5 <link rel="manifest" href="resources/push_manifest.json"> |
| 6 <script src="../resources/testharness.js"></script> | 6 <script src="../resources/testharness.js"></script> |
| 7 <script src="../resources/testharnessreport.js"></script> | 7 <script src="../resources/testharnessreport.js"></script> |
| 8 <script src="../serviceworker/resources/test-helpers.js"></script> | 8 <script src="../serviceworker/resources/test-helpers.js"></script> |
| 9 </head> | 9 </head> |
| 10 <body> | 10 <body> |
| 11 <script> | 11 <script> |
| 12 async_test(function(test) { | 12 async_test(function(test) { |
| 13 var workerUrl = 'resources/empty_worker.js'; | 13 var workerUrl = 'resources/empty_worker.js'; |
| 14 var workerScope = 'resources/scope/' + location.pathname; | 14 var workerScope = 'resources/scope/' + location.pathname; |
| 15 var swRegistration; | 15 var swRegistration; |
| 16 service_worker_unregister_and_register(test, workerUrl, workerScope) | 16 service_worker_unregister_and_register(test, workerUrl, workerScope) |
| 17 .then(function(serviceWorkerRegistration) { | 17 .then(function(serviceWorkerRegistration) { |
| 18 swRegistration = serviceWorkerRegistration; | 18 swRegistration = serviceWorkerRegistration; |
| 19 return wait_for_state(test, swRegistration.installing, 'activated'); | 19 return wait_for_state(test, swRegistration.installing, 'activated'); |
| 20 }) | 20 }) |
| 21 .then(function() { | 21 .then(function() { |
| 22 // If running manually, deny permission when prompted. | 22 // If running manually, grant permission when prompted. |
| 23 if (self.testRunner) | 23 if (self.testRunner) |
| 24 testRunner.setPushMessagingPermission(location.origin, false); | 24 testRunner.setPushMessagingPermission(location.origin, true); |
| 25 return swRegistration.pushManager.register(); | 25 return swRegistration.pushManager.register(); |
| 26 }) | 26 }) |
| 27 .then(function(pushRegistration) { | 27 .then(function(pushRegistration) { |
| 28 assert_unreached('Registration must not succeed after permission is denied.'); | 28 return pushRegistration.unregister(); |
|
Michael van Ouwerkerk
2014/12/12 12:18:04
nit for ultimate completeness:
assert_inherits(pus
mlamouri (slow - plz ping)
2014/12/15 10:55:07
Done.
| |
| 29 }, function(e) { | 29 }) |
| 30 assert_equals(e.name, 'AbortError'); | 30 .then(function(unregistration_result) { |
| 31 assert_equals(e.message, 'Registration failed - permission denied'); | 31 assert_true(unregistration_result); |
|
Michael van Ouwerkerk
2014/12/12 12:18:04
nit: add 'Unregistration must succeed' as second a
mlamouri (slow - plz ping)
2014/12/15 10:55:07
Done.
| |
| 32 // FIXME: we should add another call to unregister(). It should then | |
| 33 // fail. | |
| 34 // FIXME: we should check that there is no more push registration | |
| 35 // object available if we query the registrations. | |
| 32 return service_worker_unregister_and_done(test, workerScope); | 36 return service_worker_unregister_and_done(test, workerScope); |
| 33 }) | 37 }) |
| 34 .catch(unreached_rejection(test)); | 38 .catch(unreached_rejection(test)); |
| 35 }, 'register() is rejected when permission has been denied'); | 39 }, 'unregister() succeeds if called after a successful registration'); |
| 36 </script> | 40 </script> |
| 37 </body> | 41 </body> |
| 38 </html> | 42 </html> |
| OLD | NEW |
