Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: google_apis/gcm/engine/mcs_client.cc

Issue 793883003: [GCM] Fix gcm network change handling before connect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix leak Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gcm/engine/connection_factory_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/engine/mcs_client.cc
diff --git a/google_apis/gcm/engine/mcs_client.cc b/google_apis/gcm/engine/mcs_client.cc
index 9b5dc6e940ba5139c58b266bad8a24db191ee849..f952839a59e0567efb0f3bc1d38588e5540d5f81 100644
--- a/google_apis/gcm/engine/mcs_client.cc
+++ b/google_apis/gcm/engine/mcs_client.cc
@@ -198,7 +198,6 @@ void MCSClient::Initialize(
weak_ptr_factory_.GetWeakPtr()),
base::Bind(&MCSClient::MaybeSendMessage,
weak_ptr_factory_.GetWeakPtr()));
- connection_handler_ = connection_factory_->GetConnectionHandler();
stream_id_out_ = 1; // Login request is hardcoded to id 1.
@@ -291,6 +290,7 @@ void MCSClient::Login(uint64 android_id, uint64 security_token) {
state_ = CONNECTING;
connection_factory_->Connect();
+ connection_handler_ = connection_factory_->GetConnectionHandler();
}
void MCSClient::SendMessage(const MCSMessage& message) {
« no previous file with comments | « google_apis/gcm/engine/connection_factory_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698