Chromium Code Reviews

Issue 793873002: Don't cap the FEGaussian max kernel size. (Closed)

Created:
6 years ago by Stephen White
Modified:
6 years ago
Reviewers:
f(malita)
CC:
blink-reviews, Dominik Röttsches, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Project:
blink
Visibility:
Public.

Description

Don't cap the FEGaussian max kernel size. This is now wrong, since we now do all filter traversals in Blink in world space, and filters don't know their correct device-space size until playback time anyway (thanks to pinch-zoom and hidpi). Skia will take care of applying the appropriate device-space limit. BUG=438844 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186886

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+2 lines, -4 lines)
M Source/platform/graphics/filters/FEGaussianBlur.cpp View 2 chunks +2 lines, -4 lines 0 comments

Messages

Total messages: 6 (2 generated)
Stephen White
Florin: PTAL. Thanks!
6 years ago (2014-12-10 20:40:57 UTC) #2
f(malita)
lgtm
6 years ago (2014-12-10 20:44:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793873002/1
6 years ago (2014-12-10 21:11:38 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-10 22:39:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186886

Powered by Google App Engine