Issue 793873002: Don't cap the FEGaussian max kernel size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 793873002: Don't cap the FEGaussian max kernel size. (Closed)

Created:
6 years ago by Stephen White

Modified:
6 years ago

Reviewers:
f(malita)

CC:
blink-reviews, Dominik Röttsches, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Don't cap the FEGaussian max kernel size. This is now wrong, since we now do all filter traversals in Blink in world space, and filters don't know their correct device-space size until playback time anyway (thanks to pinch-zoom and hidpi). Skia will take care of applying the appropriate device-space limit. BUG=438844 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186886

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	Source/platform/graphics/filters/FEGaussianBlur.cpp	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793873002/1

6 years ago (2014-12-10 21:11:38 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-10 22:39:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186886

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages