Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 793783003: Move infobar constants and the code that uses them from components/ to chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NULL -> nullptr Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/browser_window_controller.h" 5 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
6 6
7 #import "base/mac/mac_util.h" 7 #import "base/mac/mac_util.h"
8 #include "base/mac/sdk_forward_declarations.h" 8 #include "base/mac/sdk_forward_declarations.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 16 matching lines...) Expand all
27 #import "chrome/browser/ui/cocoa/infobars/infobar_cocoa.h" 27 #import "chrome/browser/ui/cocoa/infobars/infobar_cocoa.h"
28 #import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h" 28 #import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h"
29 #import "chrome/browser/ui/cocoa/infobars/infobar_controller.h" 29 #import "chrome/browser/ui/cocoa/infobars/infobar_controller.h"
30 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" 30 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
31 #import "chrome/browser/ui/cocoa/profiles/avatar_base_controller.h" 31 #import "chrome/browser/ui/cocoa/profiles/avatar_base_controller.h"
32 #import "chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h" 32 #import "chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h"
33 #import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h" 33 #import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
34 #include "chrome/browser/ui/extensions/application_launch.h" 34 #include "chrome/browser/ui/extensions/application_launch.h"
35 #include "chrome/browser/ui/find_bar/find_bar.h" 35 #include "chrome/browser/ui/find_bar/find_bar.h"
36 #include "chrome/browser/ui/find_bar/find_bar_controller.h" 36 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
37 #include "chrome/browser/ui/infobar_container_delegate.h"
37 #include "chrome/browser/ui/tabs/tab_strip_model.h" 38 #include "chrome/browser/ui/tabs/tab_strip_model.h"
38 #include "chrome/test/base/in_process_browser_test.h" 39 #include "chrome/test/base/in_process_browser_test.h"
39 #include "chrome/test/base/testing_profile.h" 40 #include "chrome/test/base/testing_profile.h"
40 #include "content/public/browser/web_contents.h" 41 #include "content/public/browser/web_contents.h"
41 #include "content/public/test/test_utils.h" 42 #include "content/public/test/test_utils.h"
42 #import "testing/gtest_mac.h" 43 #import "testing/gtest_mac.h"
43 #import "third_party/ocmock/OCMock/OCMock.h" 44 #import "third_party/ocmock/OCMock/OCMock.h"
44 #import "ui/base/cocoa/nsview_additions.h" 45 #import "ui/base/cocoa/nsview_additions.h"
45 #include "ui/gfx/animation/slide_animation.h" 46 #include "ui/gfx/animation/slide_animation.h"
46 47
(...skipping 549 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 InfoBarTipStretchedWhenBookmarkBarStatusChanged) { 597 InfoBarTipStretchedWhenBookmarkBarStatusChanged) {
597 EXPECT_FALSE([controller() isBookmarkBarVisible]); 598 EXPECT_FALSE([controller() isBookmarkBarVisible]);
598 ShowInfoBar(browser()); 599 ShowInfoBar(browser());
599 // The infobar tip is animated during the infobar is being added, wait until 600 // The infobar tip is animated during the infobar is being added, wait until
600 // it completes. 601 // it completes.
601 WaitForTopInfoBarAnimationToFinish(); 602 WaitForTopInfoBarAnimationToFinish();
602 603
603 EXPECT_FALSE([[controller() infoBarContainerController] 604 EXPECT_FALSE([[controller() infoBarContainerController]
604 shouldSuppressTopInfoBarTip]); 605 shouldSuppressTopInfoBarTip]);
605 606
606 NSInteger max_tip_height = infobars::InfoBar::kMaximumArrowTargetHeight + 607 NSInteger max_tip_height =
607 infobars::InfoBar::kSeparatorLineHeight; 608 InfoBarContainerDelegate::kMaximumArrowTargetHeight +
609 InfoBarContainerDelegate::kSeparatorLineHeight;
608 610
609 chrome::ExecuteCommand(browser(), IDC_SHOW_BOOKMARK_BAR); 611 chrome::ExecuteCommand(browser(), IDC_SHOW_BOOKMARK_BAR);
610 WaitForBookmarkBarAnimationToFinish(); 612 WaitForBookmarkBarAnimationToFinish();
611 EXPECT_TRUE([controller() isBookmarkBarVisible]); 613 EXPECT_TRUE([controller() isBookmarkBarVisible]);
612 EXPECT_EQ(std::min(GetExpectedTopInfoBarTipHeight(), max_tip_height), 614 EXPECT_EQ(std::min(GetExpectedTopInfoBarTipHeight(), max_tip_height),
613 [[controller() infoBarContainerController] overlappingTipHeight]); 615 [[controller() infoBarContainerController] overlappingTipHeight]);
614 616
615 chrome::ExecuteCommand(browser(), IDC_SHOW_BOOKMARK_BAR); 617 chrome::ExecuteCommand(browser(), IDC_SHOW_BOOKMARK_BAR);
616 WaitForBookmarkBarAnimationToFinish(); 618 WaitForBookmarkBarAnimationToFinish();
617 EXPECT_FALSE([controller() isBookmarkBarVisible]); 619 EXPECT_FALSE([controller() isBookmarkBarVisible]);
(...skipping 10 matching lines...) Expand all
628 VerifyWindowControlsZOrder(); 630 VerifyWindowControlsZOrder();
629 [controller() removeOverlay]; 631 [controller() removeOverlay];
630 VerifyWindowControlsZOrder(); 632 VerifyWindowControlsZOrder();
631 633
632 // Toggle immersive fullscreen, then verify z order. In immersive fullscreen, 634 // Toggle immersive fullscreen, then verify z order. In immersive fullscreen,
633 // there are no window controls. 635 // there are no window controls.
634 [controller() enterImmersiveFullscreen]; 636 [controller() enterImmersiveFullscreen];
635 [controller() exitImmersiveFullscreen]; 637 [controller() exitImmersiveFullscreen];
636 VerifyWindowControlsZOrder(); 638 VerifyWindowControlsZOrder();
637 } 639 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698