Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 793763003: Gradient shaders: make fPtsToUnit const, pre-cache getType(). (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Gradient shaders: make fPtsToUnit const, pre-cache getType(). This prevents races when calling fPtsToUnit.getType() from multiple threads. This introduces a small amount of redundant code in SkTwoPointRadialGradient, but it's probably optimized together into no extra run-time work. BUG=437511 Committed: https://skia.googlesource.com/skia/+/cc695fee81613dc92746c1c6bb27f45cfc6ce73e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -54 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 3 chunks +9 lines, -11 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +7 lines, -3 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 2 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtklein
6 years ago (2014-12-10 18:19:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793763003/1
6 years ago (2014-12-10 18:20:05 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-10 18:20:06 UTC) #5
reed1
6 years ago (2014-12-10 18:25:46 UTC) #6
reed1
lgtm
6 years ago (2014-12-10 18:26:31 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-10 18:29:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cc695fee81613dc92746c1c6bb27f45cfc6ce73e

Powered by Google App Engine
This is Rietveld 408576698