src/compiler/register-allocator.cc - Issue 793683002: [turbofan] enable stack slot reuse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/register-allocator.cc

Issue 793683002: [turbofan] enable stack slot reuse (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/register-allocator.cc

diff --git a/src/compiler/register-allocator.cc b/src/compiler/register-allocator.cc

index a4f3c6ef0ad5d8372ce99e18058b6f1cf0521710..6cdb51f5a6a4939b577af45069b995030ae16af5 100644

--- a/src/compiler/register-allocator.cc

+++ b/src/compiler/register-allocator.cc

@@ -965,8 +965,8 @@ SpillRange* RegisterAllocator::AssignSpillRangeToLiveRange(LiveRange* range) {

bool RegisterAllocator::TryReuseSpillForPhi(LiveRange* range) {

DCHECK(FLAG_turbo_reuse_spill_slots);

- DCHECK(range->HasNoSpillType());

if (range->IsChild() || !range->is_phi()) return false;

+ DCHECK(range->HasNoSpillType());

auto lookup = phi_map_.find(range->id());

DCHECK(lookup != phi_map_.end());

« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »