chromecast/browser/devtools/remote_debugging_server.h - Issue 793663007: Set RemoteDebuggingServer port based on "remote-debugging-port" flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/devtools/remote_debugging_server.h

Issue 793663007: Set RemoteDebuggingServer port based on "remote-debugging-port" flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/browser/android/cast_window_manager.cc ('k') | chromecast/browser/devtools/remote_debugging_server.cc » ('j') | chromecast/browser/devtools/remote_debugging_server.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/devtools/remote_debugging_server.h

diff --git a/chromecast/browser/devtools/remote_debugging_server.h b/chromecast/browser/devtools/remote_debugging_server.h

index 399b34449f91c1f137ef78ad41c9f48ccc5aef40..146f137fc2ad93c2d9c6812ea2409838f691c467 100644

--- a/chromecast/browser/devtools/remote_debugging_server.h

+++ b/chromecast/browser/devtools/remote_debugging_server.h

@@ -23,8 +23,8 @@ class RemoteDebuggingServer {

~RemoteDebuggingServer();

private:

- // Called on port number changed.

- void OnPortChanged();

+ // Called when pref_enabled_ is changed.

+ void OnEnabledChanged();

// Returns whether or not the remote debugging server should be available

// on device startup.

@@ -32,7 +32,7 @@ class RemoteDebuggingServer {

scoped_ptr<devtools_http_handler::DevToolsHttpHandler> devtools_http_handler_;

- IntegerPrefMember pref_port_;

+ BooleanPrefMember pref_enabled_;

uint16 port_;

DISALLOW_COPY_AND_ASSIGN(RemoteDebuggingServer);