chrome/browser/safe_browsing/safe_browsing_database.cc - Issue 793663003: Fix a race condition in SafeBrowsingDatabaseNew::IsCsdWhitelistKillSwitchOn()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database.cc

Issue 793663003: Fix a race condition in SafeBrowsingDatabaseNew::IsCsdWhitelistKillSwitchOn() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a2_threadchecks_rebased

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/safe_browsing_database.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_database.cc b/chrome/browser/safe_browsing/safe_browsing_database.cc

index 920af7c338987729cf575eb41b6bbf49ad42ab48..5160c654fca8f5618ba01ce208b4ddfee1ea0d8a 100644

--- a/chrome/browser/safe_browsing/safe_browsing_database.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_database.cc

@@ -1696,5 +1696,6 @@ bool SafeBrowsingDatabaseNew::IsMalwareIPMatchKillSwitchOn() {

}

bool SafeBrowsingDatabaseNew::IsCsdWhitelistKillSwitchOn() {

+ base::AutoLock locked(lookup_lock_);

return csd_whitelist_.second;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »