Issue 793613003: Revert of Run "gn format" on v8's BUILD.gn file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 793613003: Revert of Run "gn format" on v8's BUILD.gn file. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach

Modified:
5 years, 11 months ago

Reviewers:
brettw, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Run "gn format" on v8's BUILD.gn file. (patchset #1 id:1 of https://codereview.chromium.org/787873003/) Reason for revert: Need to revert in order to revert https://codereview.chromium.org/832413005/ Original issue's description: > Run "gn format" on v8's BUILD.gn file. > > There should be no functional change. > > This is a reland of a portion of https://codereview.chromium.org/834113005/ > > Committed: https://crrev.com/e1d957268d154e7fb7abd5a6cad54f602badc9b8 > Cr-Commit-Position: refs/heads/master@{#25986} TBR=jochen@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6c6233c1e76bf364df81c79426b9418bb13d6fc9 Cr-Commit-Position: refs/heads/master@{#25990}

Created: 5 years, 11 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -155 lines)			Patch
	M	BUILD.gn	View		21 chunks	+148 lines, -155 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of Run "gn format" on v8's BUILD.gn file.

5 years, 11 months ago (2015-01-08 10:47:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793613003/1

5 years, 11 months ago (2015-01-08 10:48:00 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-08 10:48:20 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6c6233c1e76bf364df81c79426b9418bb13d6fc9
Cr-Commit-Position: refs/heads/master@{#25990}