Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 793573003: With V2 hotwording enabled, don't inform the start page that the launcher has opened. (Closed)

Created:
6 years ago by Anand Mistry (off Chromium)
Modified:
6 years ago
Reviewers:
xiyuan, Jun Mukai
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

With V2 hotwording enabled, don't inform the start page that the launcher has opened. BUG=440600 Committed: https://crrev.com/823f1f88ef2be9c758faf2269e0d3ec61de473e4 Cr-Commit-Position: refs/heads/master@{#308047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/browser/ui/webui/app_list/start_page_handler.cc View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Anand Mistry (off Chromium)
6 years ago (2014-12-10 05:11:13 UTC) #2
xiyuan
mukai is a better reviewer.
6 years ago (2014-12-10 06:26:30 UTC) #4
Jun Mukai
lgtm
6 years ago (2014-12-11 18:22:43 UTC) #5
Anand Mistry (off Chromium)
On 2014/12/10 06:26:30, xiyuan wrote: > mukai is a better reviewer. Still need an OWNERS ...
6 years ago (2014-12-12 00:06:19 UTC) #6
xiyuan
On 2014/12/12 00:06:19, Anand Mistry wrote: > On 2014/12/10 06:26:30, xiyuan wrote: > > mukai ...
6 years ago (2014-12-12 00:09:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793573003/1
6 years ago (2014-12-12 00:14:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 03:43:21 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-12 03:44:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/823f1f88ef2be9c758faf2269e0d3ec61de473e4
Cr-Commit-Position: refs/heads/master@{#308047}

Powered by Google App Engine
This is Rietveld 408576698