Source/web/tests/WebFrameTest.cpp - Issue 793493003: Prepare to replicate sandbox flags for OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 793493003: Prepare to replicate sandbox flags for OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Second round of dcheng's comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 054308b7cab5dedacbaaa2c792b5f9b8ade5261f..dfb1cad8db694e1cf15e0f8856f55c7774255073 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -6622,7 +6622,7 @@ TEST_F(WebFrameTest, EmbedderTriggeredDetachWithRemoteMainFrame)

WebView* view = WebView::create(&viewClient);

view->setMainFrame(WebRemoteFrame::create(&remoteClient));

FrameTestHelpers::TestWebFrameClient childFrameClient;

- WebLocalFrame* childFrame = view->mainFrame()->toWebRemoteFrame()->createLocalChild("", &childFrameClient);

+ WebLocalFrame* childFrame = view->mainFrame()->toWebRemoteFrame()->createLocalChild("", WebSandboxFlags::None, &childFrameClient);

// Purposely keep the LocalFrame alive so it's the last thing to be destroyed.

RefPtrWillBePersistent<Frame> childCoreFrame = toCoreFrame(childFrame);

« no previous file with comments | « Source/web/WebRemoteFrameImpl.cpp ('k') | public/web/WebRemoteFrame.h » ('j') | no next file with comments »