Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 793463004: Fix crash when using the language picker on iOS (Closed)

Created:
5 years, 11 months ago by droger
Modified:
5 years, 11 months ago
Reviewers:
jif
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when using the language picker on iOS The crash was happening because the wrong constructor of scoped_nsobject, because the template parameter did not exactly match the declaration. The automatic conversion to pointer was used, and the crash happened because the object was not retained. With the new code, the copy constructor is used instead, as was intended. Committed: https://crrev.com/9c7b33826df535585ecb915b7d5eb34f37388385 Cr-Commit-Position: refs/heads/master@{#311446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ios/chrome/browser/translate/before_translate_infobar_controller.mm View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
droger
5 years, 11 months ago (2015-01-14 09:23:02 UTC) #2
jif
lgtm
5 years, 11 months ago (2015-01-14 09:33:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793463004/1
5 years, 11 months ago (2015-01-14 09:34:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 10:29:30 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 10:31:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c7b33826df535585ecb915b7d5eb34f37388385
Cr-Commit-Position: refs/heads/master@{#311446}

Powered by Google App Engine
This is Rietveld 408576698