Update chromedriver to use the new version of LaunchProcess.

Update chromedriver to use the new version of LaunchProcess.

BUG=417532
Committed: https://crrev.com/721c70f32d8c81f9409152d854ca458b6c4094a8
Cr-Commit-Position: refs/heads/master@{#307999}

[rvargas (doing something else), 2014-12-10 00:19:42]

rvargas@chromium.org changed reviewers:
+ samuong@chromium.org

[samuong, 2014-12-10 20:44:55]

lgtm with one minor comment

https://codereview.chromium.org/793453002/diff/1/chrome/test/chromedriver/chr...
File chrome/test/chromedriver/chrome/chrome_desktop_impl.cc (left):

https://codereview.chromium.org/793453002/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/chrome_desktop_impl.cc:97:
base::CloseProcessHandle(process_);
I'm happy either way, but should we call CloseHandle() here or in
ChromeDesktopImpl::QuitImpl(), just after we call KillProcess()?

[rvargas (doing something else), 2014-12-10 21:55:26]

Thanks

https://codereview.chromium.org/793453002/diff/1/chrome/test/chromedriver/chr...
File chrome/test/chromedriver/chrome/chrome_desktop_impl.cc (left):

https://codereview.chromium.org/793453002/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/chrome_desktop_impl.cc:97:
base::CloseProcessHandle(process_);
On 2014/12/10 20:44:55, samuong wrote:
> I'm happy either way, but should we call CloseHandle() here or in
> ChromeDesktopImpl::QuitImpl(), just after we call KillProcess()?

Not calling Close is the same as calling it here (which is why I removed the
call, as it doesn't change the old behavior).

I guess it could be closed from Quit. I don't *think* it makes any difference.

If it is the same to you, I'll leave it as is.

[samuong, 2014-12-11 19:35:33]

On 2014/12/10 21:55:26, rvargas wrote:
> Thanks
> 
>
https://codereview.chromium.org/793453002/diff/1/chrome/test/chromedriver/chr...
> File chrome/test/chromedriver/chrome/chrome_desktop_impl.cc (left):
> 
>
https://codereview.chromium.org/793453002/diff/1/chrome/test/chromedriver/chr...
> chrome/test/chromedriver/chrome/chrome_desktop_impl.cc:97:
> base::CloseProcessHandle(process_);
> On 2014/12/10 20:44:55, samuong wrote:
> > I'm happy either way, but should we call CloseHandle() here or in
> > ChromeDesktopImpl::QuitImpl(), just after we call KillProcess()?
> 
> Not calling Close is the same as calling it here (which is why I removed the
> call, as it doesn't change the old behavior).
> 
> I guess it could be closed from Quit. I don't *think* it makes any difference.
> 
> If it is the same to you, I'll leave it as is.

sure, sgtm

[rvargas (doing something else), 2014-12-11 22:08:54]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2014-12-11 23:08:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/793453002/1

[commit-bot: I haz the power, 2014-12-11 23:21:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-11 23:21:45]

Patchset 1 (id:??) landed as
https://crrev.com/721c70f32d8c81f9409152d854ca458b6c4094a8
Cr-Commit-Position: refs/heads/master@{#307999}