Issue 79343009: Rework BuildCheckString() to be compatible with the other BuildCheck*() methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 79343009: Rework BuildCheckString() to be compatible with the other BuildCheck*() methods. (Closed)

Created:
7 years, 1 month ago by Benedikt Meurer

Modified:
7 years, 1 month ago

Reviewers:
mvstanton, Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Rework BuildCheckString() to be compatible with the other BuildCheck*() methods. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17985

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -23 lines)			Patch
M	src/code-stubs-hydrogen.cc	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	src/hydrogen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.cc	View	2 chunks	+9 lines, -14 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

Hey Michael, This is trivial cleanup. Using HCheckInstanceType, we ensure that the dependencies are correct ...

7 years, 1 month ago (2013-11-21 13:31:16 UTC) #1

Benedikt Meurer

7 years, 1 month ago (2013-11-22 07:27:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17985 (presubmit successful).