Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 793403003: Move BackgroundContents to the directory in which it belongs. (Closed)

Created:
6 years ago by Avi (use Gerrit)
Modified:
6 years ago
CC:
chromium-reviews, extensions-reviews_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, ajwong+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pageidcrash
Project:
chromium
Visibility:
Public.

Description

Move BackgroundContents to the directory in which it belongs. BUG=77790 TEST=no change; moving two files TBR=ben@chromium.org Committed: https://crrev.com/71d0f76e70fbc93eec03c5a5aab35917f5a24100 Cr-Commit-Position: refs/heads/master@{#308357}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : gypi change #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -281 lines) Patch
A + chrome/browser/background/background_contents.h View 3 chunks +6 lines, -5 lines 0 comments Download
A + chrome/browser/background/background_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/first_run/drive_first_run_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/tab_contents/background_contents.h View 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/browser/tab_contents/background_contents.cc View 1 chunk +0 lines, -162 lines 0 comments Download
M chrome/browser/task_manager/background_information.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Avi (use Gerrit)
Andrew, I think this belongs here more than in tab_contents. It's mostly just a move, ...
6 years ago (2014-12-12 01:47:16 UTC) #2
Andrew T Wilson (Slow)
LGTM - no objections to this change.
6 years ago (2014-12-15 08:59:28 UTC) #3
Avi (use Gerrit)
TBRing; this is moving a file with the permission of the OWNERS and approval is ...
6 years ago (2014-12-15 15:21:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793403003/60001
6 years ago (2014-12-15 15:22:43 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-15 16:08:55 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-15 16:09:35 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/71d0f76e70fbc93eec03c5a5aab35917f5a24100
Cr-Commit-Position: refs/heads/master@{#308357}

Powered by Google App Engine
This is Rietveld 408576698