Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/services/gcm/push_messaging_service_impl.h

Issue 793403002: Implement WebPushProvider.unregister() in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mvan_2
Patch Set: jochen review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/push_messaging_service_impl.h
diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.h b/chrome/browser/services/gcm/push_messaging_service_impl.h
index 8597eb63e69c2aa6b5b4f404326ce71ed62aff6b..a2c7d98fe5d9762fe670388db4022473ae1adb8c 100644
--- a/chrome/browser/services/gcm/push_messaging_service_impl.h
+++ b/chrome/browser/services/gcm/push_messaging_service_impl.h
@@ -64,6 +64,10 @@ class PushMessagingServiceImpl : public content::PushMessagingService,
int64 service_worker_registration_id,
const std::string& sender_id,
const content::PushMessagingService::RegisterCallback& callback) override;
+ void Unregister(
+ const GURL& requesting_origin,
+ int64 service_worker_registration_id,
+ const content::PushMessagingService::UnregisterCallback&) override;
// TODO(mvanouwerkerk): Delete once the Push API flows through platform.
// https://crbug.com/389194
blink::WebPushPermissionStatus GetPermissionStatus(
@@ -100,11 +104,11 @@ class PushMessagingServiceImpl : public content::PushMessagingService,
const content::PushMessagingService::RegisterCallback& callback,
bool allow);
- // TODO(mvanouwerkerk): this will need to be extended and move to the
- // PushMessagingService interface later.
- void Unregister(const PushMessagingApplicationId& application_id);
+ void Unregister(const PushMessagingApplicationId& application_id,
+ const content::PushMessagingService::UnregisterCallback&);
- void DidUnregister(GCMClient::Result result);
+ void DidUnregister(const content::PushMessagingService::UnregisterCallback&,
+ GCMClient::Result result);
// Helper method that checks if a given origin is allowed to use Push.
bool HasPermission(const GURL& origin);
« no previous file with comments | « chrome/browser/services/gcm/push_messaging_browsertest.cc ('k') | chrome/browser/services/gcm/push_messaging_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698