content/child/push_messaging/push_dispatcher.cc - Issue 793403002: Implement WebPushProvider.unregister() in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/push_messaging/push_dispatcher.cc

Issue 793403002: Implement WebPushProvider.unregister() in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mvan_2

Patch Set: browsertests and override fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/push_messaging/push_dispatcher.cc

diff --git a/content/child/push_messaging/push_dispatcher.cc b/content/child/push_messaging/push_dispatcher.cc

index 09ee1ccf43770ff49c6b7b03d738cdc131c94283..a807104fbd687e72335d2b526ce0e4023af52606 100644

--- a/content/child/push_messaging/push_dispatcher.cc

+++ b/content/child/push_messaging/push_dispatcher.cc

@@ -72,7 +72,8 @@ bool PushDispatcher::ShouldHandleMessage(const IPC::Message& msg) {

return msg.type() == PushMessagingMsg_RegisterFromWorkerSuccess::ID ||

msg.type() == PushMessagingMsg_RegisterFromWorkerError::ID ||

msg.type() == PushMessagingMsg_GetPermissionStatusSuccess::ID ||

- msg.type() == PushMessagingMsg_GetPermissionStatusError::ID;

+ msg.type() == PushMessagingMsg_GetPermissionStatusError::ID ||

+ msg.type() == PushMessagingMsg_UnregisterResponse::ID;

}

} // namespace content