Chromium Code Reviews| Index: content/browser/push_messaging/push_messaging_message_filter.h |
| diff --git a/content/browser/push_messaging/push_messaging_message_filter.h b/content/browser/push_messaging/push_messaging_message_filter.h |
| index cfb2f6afeb6aef31991017c80f07929ea2d7bc7c..a08c2a21114a531dc0b554f0fcf14ba517d4859c 100644 |
| --- a/content/browser/push_messaging/push_messaging_message_filter.h |
| +++ b/content/browser/push_messaging/push_messaging_message_filter.h |
| @@ -70,9 +70,16 @@ class PushMessagingMessageFilter : public BrowserMessageFilter { |
| void OnGetPermissionStatus(int request_id, |
| int64 service_worker_registration_id); |
| + void OnUnregister(int request_id, |
|
johnme
2014/12/12 15:20:07
Please use the following order when adding methods
mlamouri (slow - plz ping)
2014/12/15 11:29:36
Not sure what you wanted here. I've added an "unre
johnme
2014/12/15 12:07:16
Sorry, I meant to put all the unregister methods u
|
| + int64 service_worker_registration_id); |
| + |
| void RegisterOnUI(const RegisterData& data, |
| const std::string& sender_id); |
| + void UnregisterOnUI(const GURL& requesting_origin, |
| + int64 service_worker_registration_id, |
| + int request_id); |
|
Michael van Ouwerkerk
2014/12/12 13:55:41
Please keep request_id as the first argument and s
mlamouri (slow - plz ping)
2014/12/15 11:29:36
Done.
|
| + |
| // TODO(mvanouwerkerk): Delete once the Push API flows through platform. |
| // https://crbug.com/389194 |
| void DoPermissionStatusRequest(const GURL& requesting_origin, |
| @@ -100,6 +107,7 @@ class PushMessagingMessageFilter : public BrowserMessageFilter { |
| void SendRegisterSuccess(const RegisterData& data, |
| const GURL& push_endpoint, |
| const std::string& push_registration_id); |
| + void DidUnregister(int request_id, bool result); |
| // Returns a push messaging service. The embedder owns the service, and is |
| // responsible for ensuring that it outlives RenderProcessHost. It's valid to |