Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1239)

Unified Diff: content/public/common/push_messaging_status.h

Issue 793403002: Implement WebPushProvider.unregister() in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mvan_2
Patch Set: review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/push_messaging_status.h
diff --git a/content/public/common/push_messaging_status.h b/content/public/common/push_messaging_status.h
index 5469c9eabfbb62df5e9eb958d5b31e8d23ed1fa3..b9cac4dfa1a94dfe8e804b3833fb77665a57c25c 100644
--- a/content/public/common/push_messaging_status.h
+++ b/content/public/common/push_messaging_status.h
@@ -90,6 +90,21 @@ enum PushDeliveryStatus {
PUSH_DELIVERY_STATUS_LAST = PUSH_DELIVERY_STATUS_EVENT_WAITUNTIL_REJECTED
};
+// Push unregistration success / error codes for internal use & reporting.
+enum PushUnregistrationStatus {
johnme 2014/12/16 16:31:59 Please move this above PushGetRegistrationStatus.
mlamouri (slow - plz ping) 2014/12/16 18:26:16 Done.
+ // The unregistration was successful.
+ PUSH_UNREGISTRATION_SUCCESS_UNREGISTER,
johnme 2014/12/16 16:31:59 PUSH_UNREGISTRATION_STATUS_SUCCESS_UNREGISTERED? S
mlamouri (slow - plz ping) 2014/12/16 18:26:16 Done.
+
+ // The registration was already unregistered.
+ PUSH_UNREGISTRATION_SUCCESS_WAS_UNREGISTERED,
+
+ // The unregistration did not happen because of a network error.
+ PUSH_UNREGISTRATION_NETWORK_ERROR,
+
+ // The unregistration did not happen because of a miscellaneous error.
+ PUSH_UNREGISTRATION_UNKNOWN_ERROR,
+};
+
const char* PushRegistrationStatusToString(PushRegistrationStatus status);
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698